Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to glue releases #53

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Pin to glue releases #53

merged 1 commit into from
Jan 25, 2024

Conversation

mattmoor
Copy link
Member

set netnum to avoid the breaking change.

set `netnum` to avoid the breaking change.

Signed-off-by: Matt Moore <[email protected]>
@mattmoor mattmoor enabled auto-merge (squash) January 25, 2024 20:58
name = var.name
project_id = var.project_id
regions = var.regions
netnum_offset = 1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this actions are failing with:

module.networking.google_compute_subnetwork.regional["us-central1"]: Destroying... [id=projects/octo-sts/regions/us-central1/subnetworks/octo-sts-us-central1]
Error: Terraform exited with code 1.
│ 
╵
Error: Process completed with exit code 1.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were there any more details in this error? The intent of this change was to be backwards compatible and fall back to the provider project if these values weren't set.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e.g. netnum_offset should default to 0 if not provided, so I'm curious why this would be causing problems 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh i see what's going on. this is the real error:

│ Error: Error when reading or editing Subnetwork: googleapi: Error 400: The subnetwork resource 'projects/octo-sts/regions/us-central1/subnetworks/octo-sts-us-central1' is already being used by 'projects/octo-sts/regions/us-central1/addresses/serverless-ipv4-1706112377164427487', resourceInUseByAnotherResource

Previously the old network module was using a cidr address n+1 than what was given. Now we zero index so we don't waste cidr range, which changed the subnet address being used to start at 0, but the old subnet couldn't be removed because the existing cloud run resources were already using it.

So this change is just matching the previous n+1 cidr behavior as before.

@mattmoor mattmoor merged commit f7299d3 into octo-sts:main Jan 25, 2024
9 checks passed
@mattmoor mattmoor deleted the pin-releases branch January 25, 2024 21:04
name = var.name
project_id = var.project_id
regions = var.regions
netnum_offset = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were there any more details in this error? The intent of this change was to be backwards compatible and fall back to the provider project if these values weren't set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants